Messages in this thread | | | Date | Sat, 31 Jan 2009 00:40:12 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] kbuild: drop check for CONFIG_ in headers_check |
| |
* Sam Ravnborg <sam@ravnborg.org> wrote:
> The check for references to CONFIG_ symbols in exported headers turned > out to be too agressive with the current state of affairs. > After the work of Jaswinder to clean up all relevant cases we are down > to almost pure noise. > > So lets drop the check for now - we can always add it back later > should our headers be ready for that. > > Cc: Jaswinder Singh Rajput <jaswinder@kernel.org> > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > --- > Hi Ingo. > Please include this in the tip/core/header-fixes brach > as this is the natural path towards mainline. > > Jaswinder - thanks for your effort chasing all these warnings!
Applied to tip/core/header-fixes, thanks Sam for the quick patch!
Jaswinder, i think we now have a realistic chance to reach a zero baseline with these warnings, for v2.6.29. Here are the remaining warnings (summed up per file) on x86 (after Sam's patch):
17 /dev/shm/tip/usr/include/linux/reiserfs_fs.h 12 /dev/shm/tip/usr/include/linux/soundcard.h 3 /dev/shm/tip/usr/include/linux/nubus.h 2 /dev/shm/tip/usr/include/linux/in6.h 1 /dev/shm/tip/usr/include/mtd/jffs2-user.h 1 /dev/shm/tip/usr/include/linux/socket.h 1 /dev/shm/tip/usr/include/linux/coda_psdev.h 1 /dev/shm/tip/usr/include/linux/bsg.h
Ingo
| |