lkml.org 
[lkml]   [2009]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/8] checkpatch: make in_atomic ok in the core
    Date
    We say that in_atomic() is ok in the core kernel, but then always
    report it regardless of where in the kernel it is. Keep quiet if
    it is used in kernel/*.

    Signed-off-by: Andy Whitcroft <apw@canonical.com>
    ---
    scripts/checkpatch.pl | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
    index 45eb0ae..c71a0fa 100755
    --- a/scripts/checkpatch.pl
    +++ b/scripts/checkpatch.pl
    @@ -2560,7 +2560,7 @@ sub process {
    if ($line =~ /\bin_atomic\s*\(/) {
    if ($realfile =~ m@^drivers/@) {
    ERROR("do not use in_atomic in drivers\n" . $herecurr);
    - } else {
    + } elsif ($realfile !~ m@^kernel/@) {
    WARN("use of in_atomic() is incorrect outside core kernel code\n" . $herecurr);
    }
    }
    --
    1.6.1.2.419.g0d87e


    \
     
     \ /
      Last update: 2009-01-30 16:09    [W:0.152 / U:1.728 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site