lkml.org 
[lkml]   [2009]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86/powernow: fix cpus_allowed brokage when acpi=off
Rusty Russell wrote:
> On Thursday 29 January 2009 15:26:28 Yinghai Lu wrote:
>> Impact: fix current->cpus_allowed overwriting.
> ...
>> caused by
>> | commit 2fdf66b491ac706657946442789ec644cc317e1a
>> | Author: Rusty Russell <rusty@rustcorp.com.au>
>> | Date: Wed Dec 31 18:08:47 2008 -0800
>> |
>> | cpumask: convert shared_cpu_map in acpi_processor* structs to cpumask_var_t
>
> Hi Yinghai!
>
> Indeed; Mike, that contained a bad conversion of
> arch/x86/kernel/cpu/cpufreq/powernow-k8.c.
>
> This patch reverts the bad change (this code should still be converted
> to work_on_cpu of course, but that's a bigger change).
>
> Yinghai, as far as I can tell your other fixes are independent (and
> were a problem before this commit, yes?). Can you re-submit them on top
> of this patch (which is for Ingo, but against latest Linus).

no problem, after ingo pick your patch in tip/master, i will have another patch.

YH

>
> Subject: cpumask: fix powernow-k8: partial revert of 2fdf66b491ac706657946442789ec644cc317e1a
>
> Impact: fix powernow-k8 when acpi=off (or other error).
>
> There was a spurious change introduced into powernow-k8 in this patch:
> the cause if that we try to "restore" the cpus_allowed we never saved.
>
> See lkml "[PATCH] x86/powernow: fix cpus_allowed brokage when
> acpi=off" from Yinghai for the bug report.
>


\
 
 \ /
  Last update: 2009-01-30 02:49    [W:0.050 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site