Messages in this thread | | | Date | Thu, 29 Jan 2009 14:23:03 +0000 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH A 01/10] OMAP2/3: Add non-CORE DPLL rate set code and M, N programming |
| |
On Tue, Jan 27, 2009 at 07:12:47PM -0700, Paul Walmsley wrote: > +/* Non-CORE DPLL rate set code */ > + > +/* > + * omap3_noncore_dpll_program - set non-core DPLL M,N values directly > + * @clk: struct clk * of DPLL to set > + * @m: DPLL multiplier to set > + * @n: DPLL divider to set > + * @freqsel: FREQSEL value to set > + * > + * Program the DPLL with the supplied M, N values, and wait for the DPLL to > + * lock.. Returns -EINVAL upon error, or 0 upon success. > + */ > +static int omap3_noncore_dpll_program(struct clk *clk, u16 m, u8 n, u16 freqsel) > +{ > + struct dpll_data *dd; > + u32 v; > + > + if (!clk) > + return -EINVAL; > + > + dd = clk->dpll_data; > + if (!dd) > + return -EINVAL;
Final point... this is only called from the function below, which also checks that clk and clk->dpll_data are both non-NULL. So these checks are unnecessary.
> +static int omap3_noncore_dpll_set_rate(struct clk *clk, unsigned long rate) > +{ > + u16 freqsel; > + struct dpll_data *dd; > + > + if (!clk || !rate) > + return -EINVAL; > + > + dd = clk->dpll_data; > + if (!dd) > + return -EINVAL; > + > + if (rate == omap2_get_dpll_rate(clk)) > + return 0; > + > + if (dd->last_rounded_rate != rate) > + omap2_dpll_round_rate(clk, rate); > + > + if (dd->last_rounded_rate == 0) > + return -EINVAL; > + > + freqsel = _omap3_dpll_compute_freqsel(clk, dd->last_rounded_n); > + if (!freqsel) > + WARN_ON(1); > + > + omap3_noncore_dpll_program(clk, dd->last_rounded_m, dd->last_rounded_n, > + freqsel); > + > + omap3_dpll_recalc(clk); > + > + return 0; > +}
| |