lkml.org 
[lkml]   [2009]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] xen: make sysfs files behave as their names suggest
On Wed, Jan 28, 2009 at 08:31:25PM -0800, Jeremy Fitzhardinge wrote:
> Simon Horman wrote:
>> On Wed, Jan 28, 2009 at 04:50:20PM -0800, Jeremy Fitzhardinge wrote:
>>
>>> 1: make "target_kb" only accept and produce a memory size in kilobytes.
>>> 2: add a second "target" file which produces output in bytes, and will accept
>>> memparse input (scaled bytes)
>>>
>>> This fixes the rather irritating problem that writing the same value
>>> read back into target_kb would end up shrinking the domain by a factor
>>> of 1024, with generally bad results.
>>>
>>
>> Are there any compatibility issues that we should care about
>> related to this change?
>>
>
> Well, in theory, but not in practice I think.
>
> It changes the behaviour of target_kb from accepting bytes into
> kilobytes, and it no longer parses a k/m/g suffix. The old behaviour
> was a definite bug, given the name of the file, so I consider this to be
> pure bugfix. The kernel introducing this interface has only been out
> for a week or two, so I don't think there's much chance anyone has
> started relying on the buggy behaviour.

Thanks for the clarification. I have no objections.

--
Simon Horman
VA Linux Systems Japan K.K., Sydney, Australia Satellite Office
H: www.vergenet.net/~horms/ W: www.valinux.co.jp/en



\
 
 \ /
  Last update: 2009-01-29 07:47    [W:0.285 / U:0.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site