Messages in this thread | | | Subject | Re: [PATCH] use per cpu data for single cpu ipi calls | From | Peter Zijlstra <> | Date | Thu, 29 Jan 2009 12:41:56 +0100 |
| |
On Thu, 2009-01-29 at 12:13 +0100, Ingo Molnar wrote: > * Peter Zijlstra <peterz@infradead.org> wrote: > > > > Can generic_smp_call_function_single_interrupt() ever see > > > CSD_FLAG_ALLOC set now? If not, that kfree can go away. > > > > Like said above, removing that kmalloc will hurt people. > > the whole promise of generic-IPI seems to dwindle and we'll get back to > roughly where we started out from.
I'd not go that far, the per-cpu csd is a nice fallback, but removing that kmalloc is just silly.
And I see no reason why arch specific could do any better (aside from sparc which has fancy ipis).
| |