Messages in this thread | | | Date | Thu, 29 Jan 2009 20:01:19 +0900 | From | Tejun Heo <> | Subject | Re: unified percpu stuff |
| |
Jeremy Fitzhardinge wrote: > Tejun Heo wrote: >> The current tj-percpu[1] contains Brian's commit which consolidates >> load_gs_base() into switch_to_new_gdt(), > > There's a bit of a bootstrap problem using switch_to_new_gdt() on the > boot CPU: it uses smp_processor_id, which ends up doing a > percpu_read(cpu_number), which naturally crashes because %gs isn't set > up yet. Perhaps switch_to_new_gdt() should take the cpu number as a > parameter (or at least a __switch_to_new_gdt variant which does).
Please feel free to submit a patch. It being a pretty low level function, I think it would be better to convert it to take cpu_number.
Thanks.
-- tejun
| |