lkml.org 
[lkml]   [2009]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH C 09/13] OMAP3 clock: fix non-CORE DPLL rate assignment bugs
    On Wed, Jan 28, 2009 at 12:08:35PM -0700, Paul Walmsley wrote:
    > diff --git a/arch/arm/mach-omap2/clock34xx.c b/arch/arm/mach-omap2/clock34xx.c
    > index 424eed6..c943043 100644
    > --- a/arch/arm/mach-omap2/clock34xx.c
    > +++ b/arch/arm/mach-omap2/clock34xx.c
    > @@ -270,7 +270,6 @@ static int _omap3_noncore_dpll_stop(struct clk *clk)
    > static int omap3_noncore_dpll_enable(struct clk *clk)
    > {
    > int r;
    > - long rate;
    > struct dpll_data *dd;
    >
    > if (clk == &dpll3_ck)
    > @@ -286,7 +285,7 @@ static int omap3_noncore_dpll_enable(struct clk *clk)
    > r = _omap3_noncore_dpll_lock(clk);
    >
    > if (!r)
    > - clk->rate = rate;
    > + clk->rate = omap2_get_dpll_rate(clk);

    This whole patch can be viewed as another bug fix to patch 6.

    > @@ -429,6 +428,9 @@ static int omap3_noncore_dpll_set_rate(struct clk *clk, unsigned long rate)
    > ret = omap3_noncore_dpll_program(clk, dd->last_rounded_m,
    > dd->last_rounded_n, freqsel);
    >
    > + if (!ret)
    > + clk->rate = rate;
    > +

    So this is creating:

    if (...) {
    ret = something;

    if (!ret)
    clk->rate = rate;
    } else {
    ret = something else;

    if (!ret)
    clk->rate = rate;
    }

    So why not make it easier to read and more obvious:

    if (...) {
    ret = something;
    } else {
    ret = something else;
    }

    if (!ret)
    clk->rate = rate;

    > }
    >
    > omap3_dpll_recalc(clk);
    >
    >
    >
    > -------------------------------------------------------------------
    > List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
    > FAQ: http://www.arm.linux.org.uk/mailinglists/faq.php
    > Etiquette: http://www.arm.linux.org.uk/mailinglists/etiquette.php


    \
     
     \ /
      Last update: 2009-01-29 11:41    [W:0.021 / U:35.964 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site