lkml.org 
[lkml]   [2009]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Patch 01/14] Add definitions of x86_64 GRU MMRs.

    * Andrew Morton <akpm@linux-foundation.org> wrote:

    > On Thu, 22 Jan 2009 11:49:18 -0600 steiner@sgi.com wrote:
    >
    > > Add definitions for x86_64 GRU MMRs.
    >
    > Breaks x86_32:
    >
    > arch/x86/include/asm/uv/uv_mmrs.h:409: error: width of 'real_time_cmpb' exceeds its type
    > arch/x86/include/asm/uv/uv_mmrs.h:425: error: width of 'real_time_cmpc' exceeds its type
    > arch/x86/include/asm/uv/uv_mmrs.h:441: error: width of 'real_time_cmpd' exceeds its type
    > arch/x86/include/asm/uv/uv_mmrs.h:491: error: width of 'address' exceeds its type
    > <etc>
    >
    > due to stuff flike
    >
    > unsigned long real_time_cmpb : 56; /* RW */
    >
    >
    > this:
    >
    > --- a/arch/x86/kernel/io_apic.c~a
    > +++ a/arch/x86/kernel/io_apic.c
    > @@ -59,8 +59,11 @@
    > #include <asm/setup.h>
    > #include <asm/irq_remapping.h>
    > #include <asm/hpet.h>
    > +
    > +#ifdef CONFIG_X86_64
    > #include <asm/uv/uv_hub.h>
    > #include <asm/uv/uv_irq.h>
    > +#endif
    >
    > #include <mach_ipi.h>
    > #include <mach_apic.h>
    > _
    >
    > seems sufficient, but perhaps it'd be better if it was done within the
    > header?

    Modifications to this file should be submitted to the x86 tree in any
    case.

    Ingo


    \
     
     \ /
      Last update: 2009-01-29 11:39    [W:0.022 / U:91.116 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site