Messages in this thread | | | Date | Wed, 28 Jan 2009 20:31:25 -0800 | From | Jeremy Fitzhardinge <> | Subject | Re: [PATCH] xen: make sysfs files behave as their names suggest |
| |
Simon Horman wrote: > On Wed, Jan 28, 2009 at 04:50:20PM -0800, Jeremy Fitzhardinge wrote: > >> 1: make "target_kb" only accept and produce a memory size in kilobytes. >> 2: add a second "target" file which produces output in bytes, and will accept >> memparse input (scaled bytes) >> >> This fixes the rather irritating problem that writing the same value >> read back into target_kb would end up shrinking the domain by a factor >> of 1024, with generally bad results. >> > > Are there any compatibility issues that we should care about > related to this change? >
Well, in theory, but not in practice I think.
It changes the behaviour of target_kb from accepting bytes into kilobytes, and it no longer parses a k/m/g suffix. The old behaviour was a definite bug, given the name of the file, so I consider this to be pure bugfix. The kernel introducing this interface has only been out for a week or two, so I don't think there's much chance anyone has started relying on the buggy behaviour.
J
| |