Messages in this thread Patch in this message |  | | | Date | Thu, 29 Jan 2009 02:30:56 +0300 | | From | Alexander Beregalov <> | | Subject | Re: [PATCH] sata_sil: Fix build breakage |
| |
On Wed, Jan 28, 2009 at 12:08:56AM -0600, Kumar Gala wrote: > > On Jan 27, 2009, at 11:02 PM, Kumar Gala wrote: > >> The following commit introduces: >> >> commit e57db7bde7bff95ae812736ca00c73bd5271455b >> Author: Rafael J. Wysocki <rjw@sisk.pl> >> Date: Mon Jan 19 20:58:29 2009 +0100 >> >> SATA Sil: Blacklist system that spins off disks during ACPI power off >> >> the following build errors on non-x86 systems: >> >> drivers/ata/sata_sil.c: In function 'sil_broken_system_poweroff': >> drivers/ata/sata_sil.c:713: error: implicit declaration of function >> 'dmi_first_match' >> drivers/ata/sata_sil.c:713: warning: initialization makes pointer from >> integer without a cast >> >> Signed-off-by: Kumar Gala <galak@kernel.crashing.org> >> --- >> drivers/ata/sata_sil.c | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) > > > it was pointed out that fixing include/linux/dmi.h was the better way to > fix this. I've posted a patch for fixing dmi.h that supersedes this patch. >
It breaks build for me in the same way even after your fix (d8204ee2: dmi: Fix build breakage)
Subject: [PATCH] sata_sil: Fix build breakage From: Alexander Beregalov <a.beregalov@gmail.com>
Commit e57db7b (SATA Sil: Blacklist system that spins off disks during ACPI power off) breaks build like the following, in both cases when CONFIG_DMI set or not.
drivers/ata/sata_sil.c: In function 'sil_broken_system_poweroff': drivers/ata/sata_sil.c:713: error: implicit declaration of function 'dmi_first_match' drivers/ata/sata_sil.c:713: warning: initialization makes pointer from integer without a cast
sata_sil.c should include dmi.h
Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com> ---
drivers/ata/sata_sil.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/ata/sata_sil.c b/drivers/ata/sata_sil.c index bfd55b0..9f02959 100644 --- a/drivers/ata/sata_sil.c +++ b/drivers/ata/sata_sil.c @@ -44,6 +44,7 @@ #include <linux/device.h> #include <scsi/scsi_host.h> #include <linux/libata.h> +#include <linux/dmi.h> #define DRV_NAME "sata_sil" #define DRV_VERSION "2.4"
|  |