lkml.org 
[lkml]   [2009]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH -mmotm] mm: unify some pmd_*() functions
    From
    On Wed, Jan 28, 2009 at 2:41 AM, Andrew Morton
    <akpm@linux-foundation.org> wrote:
    > On Sun, 25 Jan 2009 22:35:37 +0100
    > Andrea Righi <righi.andrea@gmail.com> wrote:
    >
    >> diff --git a/include/asm-generic/pgtable-nopmd.h b/include/asm-generic/pgtable-nopmd.h
    >> index a7cdc48..b132d69 100644
    >> --- a/include/asm-generic/pgtable-nopmd.h
    >> +++ b/include/asm-generic/pgtable-nopmd.h
    >> @@ -4,6 +4,7 @@
    >> #ifndef __ASSEMBLY__
    >>
    >> #include <asm-generic/pgtable-nopud.h>
    >> +#include <asm/bug.h>
    >>
    >> struct mm_struct;
    >>
    >
    > Why not include the preferred <linux/bug.h>?

    Using linux/bug.h leads to include hell (i.e. on x86 with
    CONFIG_X86_PAE not set):
    ...
    CC arch/x86/kernel/asm-offsets.s
    In file included from include/linux/thread_info.h:55,
    from include/linux/preempt.h:9,
    from include/linux/spinlock.h:50,
    from include/linux/seqlock.h:29,
    from include/linux/time.h:8,
    from include/linux/stat.h:60,
    from include/linux/module.h:10,
    from include/linux/bug.h:4,
    from include/asm-generic/pgtable-nopmd.h:7,
    from
    /home/arighi/Software/linux/mmotm/arch/x86/include/asm/page.h:132,
    from
    /home/arighi/Software/linux/mmotm/arch/x86/include/asm/processor.h:18,
    from
    /home/arighi/Software/linux/mmotm/arch/x86/include/asm/atomic_32.h:6,
    from
    /home/arighi/Software/linux/mmotm/arch/x86/include/asm/atomic.h:2,
    from include/linux/crypto.h:20,
    from arch/x86/kernel/asm-offsets_32.c:7,
    from arch/x86/kernel/asm-offsets.c:2:
    /home/arighi/Software/linux/mmotm/arch/x86/include/asm/thread_info.h:34:
    error: expected specifier-qualifier-list before 'mm_segment_t'
    ...

    -Andrea


    \
     
     \ /
      Last update: 2009-01-28 19:03    [W:0.026 / U:1.124 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site