Messages in this thread Patch in this message | | | From | KOSAKI Motohiro <> | Subject | [PATCH] export get_task_comm() | Date | Tue, 27 Jan 2009 14:09:05 +0900 (JST) |
| |
> Hi, > > on 19 Jan 09 at 07:36, KOSAKI Motohiro wrote: > >> is there any reason why get_task_comm() is not exported in fs/exec.c? > > > In general, the only function of anybody necessarity explained is exported. > > if you want to export get_task_comm(), you need to explain reasonable > > reason. > > It's nothing that important: just want to print the executable name to the > logs during error handling. get_task_comm() is the required accessor > function. > > http://lirc.cvs.sourceforge.net/viewvc/lirc/lirc/drivers/lirc_dev/lirc_dev.c?revision=1.70&view=markup
To be honest, I don't use get_task_comm(). but I don't oppose your request.
== Subject: [PATCH] export get_task_comm()
task::comm is good debugging information and driver developer want to use this information easily.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> --- fs/exec.c | 1 + 1 file changed, 1 insertion(+)
Index: b/fs/exec.c =================================================================== --- a/fs/exec.c +++ b/fs/exec.c @@ -936,6 +936,7 @@ char *get_task_comm(char *buf, struct ta task_unlock(tsk); return buf; } +EXPORT_SYMBOL_GPL(get_task_comm); void set_task_comm(struct task_struct *tsk, char *buf) {
| |