[lkml]   [2009]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] kmalloc: Return NULL instead of link failure
    Andrew Morton wrote:
    > On Tue, 20 Jan 2009 10:53:26 -0500
    > Jeff Mahoney <> wrote:
    >> Hash: SHA1
    >> The SLAB kmalloc with a constant value isn't consistent with the other
    >> implementations because it bails out with __you_cannot_kmalloc_that_much
    >> rather than returning NULL and properly allowing the caller to fall back
    >> to vmalloc or take other action. This doesn't happen with a non-constant
    >> value or with SLOB or SLUB.
    >> Starting with 2.6.28, I've been seeing build failures on s390x. This is
    >> due to init_section_page_cgroup trying to allocate 2.5MB when the max
    >> size for a kmalloc on s390x is 2MB.
    >> It's failing because the value is constant. The workarounds at the call
    >> size are ugly and the caller shouldn't have to change behavior depending
    >> on what the backend of the API is.
    >> So, this patch eliminates the link failure and returns NULL like the
    >> other implementations.
    > OK by me, is that's what the other sl[]b.c implementations
    > do.
    > That __you_cannot_kmalloc_that_much() thing has frequently been a PITA
    > anyway - some gcc versions flub the constant_p() test and end up
    > referencing __you_cannot_kmalloc_that_much() when the callsite was
    > passing a variable `size' arg.


    > Strange patch format, but it applied.
    > I'll punt this patch in the Pekka direction.

    Applied, thanks!


     \ /
      Last update: 2009-01-27 22:57    [W:0.062 / U:14.776 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site