lkml.org 
[lkml]   [2009]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 2/2] seq_file: Properly cope with pread
    From
    Date

    Currently seq_read assumes that the offset passed
    to it is always the offset it passed to user space.
    In the case pread this assumption is broken and we
    do the wrong thing when presented with pread.

    To solve this I introduce an offset cache inside of
    struct seq_file so we know where our logical file position
    is. Then in seq_read if we try to read from another
    offset we reset our data structures and attempt
    to go to the offset user space wanted.

    Signed-off-by: Eric Biederman <ebiederm@xmission.com>
    ---
    fs/seq_file.c | 24 ++++++++++++++++++++++--
    include/linux/seq_file.h | 1 +
    2 files changed, 23 insertions(+), 2 deletions(-)

    diff --git a/fs/seq_file.c b/fs/seq_file.c
    index 2716c12..cd63d69 100644
    --- a/fs/seq_file.c
    +++ b/fs/seq_file.c
    @@ -130,6 +130,22 @@ ssize_t seq_read(struct file *file, char __user *buf, size_t size, loff_t *ppos)
    int err = 0;

    mutex_lock(&m->lock);
    +
    + /* Don't assume *ppos is where we left it */
    + if (unlikely(*ppos != m->read_pos)) {
    + m->read_pos = *ppos;
    + while ((err = traverse(m, *ppos)) == -EAGAIN)
    + ;
    + if (err) {
    + /* With prejudice... */
    + m->read_pos = 0;
    + m->version = 0;
    + m->index = 0;
    + m->count = 0;
    + goto Done;
    + }
    + }
    +
    /*
    * seq_file->op->..m_start/m_stop/m_next may do special actions
    * or optimisations based on the file->f_version, so we want to
    @@ -229,8 +245,10 @@ Fill:
    Done:
    if (!copied)
    copied = err;
    - else
    + else {
    *ppos += copied;
    + m->read_pos += copied;
    + }
    file->f_version = m->version;
    mutex_unlock(&m->lock);
    return copied;
    @@ -265,16 +283,18 @@ loff_t seq_lseek(struct file *file, loff_t offset, int origin)
    if (offset < 0)
    break;
    retval = offset;
    - if (offset != file->f_pos) {
    + if (offset != m->read_pos) {
    while ((retval=traverse(m, offset)) == -EAGAIN)
    ;
    if (retval) {
    /* with extreme prejudice... */
    file->f_pos = 0;
    + m->read_pos = 0;
    m->version = 0;
    m->index = 0;
    m->count = 0;
    } else {
    + m->read_pos = offset;
    retval = file->f_pos = offset;
    }
    }
    diff --git a/include/linux/seq_file.h b/include/linux/seq_file.h
    index 40ea505..f616f31 100644
    --- a/include/linux/seq_file.h
    +++ b/include/linux/seq_file.h
    @@ -19,6 +19,7 @@ struct seq_file {
    size_t from;
    size_t count;
    loff_t index;
    + loff_t read_pos;
    u64 version;
    struct mutex lock;
    const struct seq_operations *op;
    --
    1.5.6.3


    \
     
     \ /
      Last update: 2009-01-27 22:53    [W:0.037 / U:0.160 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site