lkml.org 
[lkml]   [2009]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] work_on_cpu: Use our own workqueue.

* Andrew Morton <akpm@linux-foundation.org> wrote:

> > But it's a general comment about fixing a general issue. The
> > currently known case is not directly relevent; that it can happen and
> > it's restricting the use of this otherwise-general API is.
>
> I think we should switch acpi-cpufreq to smp_call_function(), revert
> this stuff and ban the calling of work_on_cpu() under locks.

I agree that do_drv_read()/write() should be converted to
smp_function_call() (what it does is atomic: msr or PIO cycles).

Then work_on_cpu() can be removed for good, to not lure people into using
it. You seem to agree that work_on_cpu() is unfixable so it's far better
to offer nothing than to offer such a deceivingly named but fundamentally
limited facility.

Ingo


\
 
 \ /
  Last update: 2009-01-27 16:31    [W:0.158 / U:24.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site