Messages in this thread Patch in this message | | | Date | Tue, 27 Jan 2009 00:39:20 -0500 | From | Kyle McMartin <> | Subject | [PATCH] make checkpatch warn about access to current->comm |
| |
From: Kyle McMartin <kyle@redhat.com>
Suggest using the get_task_comm accessor versus direct access to current->comm.
Signed-off-by: Kyle McMartin <kyle@redhat.com>
---
I just mashed it in the middle of existing checks to minimize risk of collisions.
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 45eb0ae..4f2da5d 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2533,6 +2533,11 @@ sub process { $herecurr); } +# direct access to current task name is racy, suggest accessor instead. + if ($line =~ /current\-\>comm/) { + WARN("direct access to current->comm is racy, use get_task_comm() instead.\n" . $herecurr); + } + # use of NR_CPUS is usually wrong # ignore definitions of NR_CPUS and usage to define arrays as likely right if ($line =~ /\bNR_CPUS\b/ &&
| |