Messages in this thread | | | Date | Mon, 26 Jan 2009 19:32:11 -0800 | From | Sukadev Bhattiprolu <> | Subject | Re: devpts multiple instances feedback |
| |
Christoph Hellwig [hch@lst.de] wrote: | On Sat, Jan 03, 2009 at 05:15:44PM +0100, Christoph Hellwig wrote: | > This is a little untested patch to massage the mount code into about | > how it should look like: | | ping?
I was waiting for discussion on the other thread. But yes, this does simplify the code by copying in the common code in get_sb_single() and get_sb_nodev() into devpts, and eliminating the do_remount() stuff in 'single-mount' mode.
We may also be able to define an "empty" mknod_ptmx() when CONFIG_DEVPTS_MULTIPLE_INSTANCES=n and share a bit more code, but will defer that to a separate patch.
Will test this out some more and resend the modified patch.
Sukadev
| |