lkml.org 
[lkml]   [2009]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Linux 2.6.29-rc2] BUG: using smp_processor_id() in preemptible
On Sat, 24 Jan 2009, Andrew Morton wrote:
>
> Coming out of the hrtimer_hres_active() call, I assume.

Yes.

> Is this new behaviour, or were 2.6.28 and earlier doing it?

This code is there since highres was merged, but something seems to
have changed in the suspend/resume code as I'm pretty sure, that this
code was always called with interrupts disabled.

> a) remove the wrong "Called with interrupts disabled via
> on_each_cpu()" comment from retrigger_next_event(), and replace it
> with something useful and truthful.

Good point.

> b) change hres_timers_resume() to do local_irq_save/restore

Right, but I'd like to know what changed below.

Thanks,

tglx


\
 
 \ /
  Last update: 2009-01-25 13:01    [W:0.099 / U:0.496 seconds]
©2003-2011 Jasper Spaans. Advertise on this site