lkml.org 
[lkml]   [2009]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [BUG] MMC/SD: SDHC card capacity not correct
On Tue, 13 Jan 2009 16:00:21 +0800
yi li <liyi.dev@gmail.com> wrote:

> 2. Fix like this:
> --- card/block.c 2009-01-13 15:56:05.000000000 +0800
> +++ card/block.c.new 2009-01-13 15:53:45.000000000 +0800
> @@ -514,7 +514,7 @@ static int mmc_blk_probe(struct mmc_card
> if (err)
> goto out;
>
> - string_get_size(get_capacity(md->disk) << 9, STRING_UNITS_2,
> + string_get_size((u64)get_capacity(md->disk) << 9, STRING_UNITS_2,
> cap_str, sizeof(cap_str));
> printk(KERN_INFO "%s: %s %s %s %s\n",
> md->disk->disk_name, mmc_card_id(card), mmc_card_name(card),
>
> I prefer the second fix, what do you think?
>

Agreed. Send me a proper patch with a S-o-b and all that. :)

Rgds
--
-- Pierre Ossman

Linux kernel, MMC maintainer http://www.kernel.org
rdesktop, core developer http://www.rdesktop.org

WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.


\
 
 \ /
  Last update: 2009-01-24 18:49    [W:0.051 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site