Messages in this thread | | | Date | Thu, 22 Jan 2009 09:35:06 +0100 | From | Eric Sesterhenn <> | Subject | Re: [PATCH] Re: Corrupted XFS log replay oops. |
| |
* Christoph Hellwig (hch@infradead.org) wrote: > On Thu, Jan 22, 2009 at 03:37:47PM +1100, Dave Chinner wrote: > > xfs_buf_t * > > xlog_get_bp( > > xlog_t *log, > > - int num_bblks) > > + int nbblks) > > Any reason for reanming this variable? That causes quite a bit of > churn. > > > { > > - ASSERT(num_bblks > 0); > > + if (nbblks <= 0 || nbblks > log->l_logBBsize) { > > + xlog_warn("XFS: Invalid block length (0x%x) given for buffer", nbblks); > > And doesn't prevent this line from needing a linebreak to stay under 80 > characters :) > > Except for these nitpicks it looks fine to me.
Just want to report that it fixes the issue for me. Thanks, i will continue xfs testing.
Greetings, Eric
| |