lkml.org 
[lkml]   [2009]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 15/46] drivers/net/irda/irda-usb.c: fix buffer overflow
    2.6.28-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Jos-Vicente Gilabert <josevteg@gmail.com>

    commit 2950e952920811be465ec95c6b56f03dc66a05c0 upstream.

    Taken from http://bugzilla.kernel.org/show_bug.cgi?id=12397

    We're doing an sprintf of an 11-char string into an 11-char buffer.
    Whoops. It breaks firmware uploading.

    Reported-by: Jos-Vicente Gilabert <josevteg@gmail.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/net/irda/irda-usb.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/irda/irda-usb.c
    +++ b/drivers/net/irda/irda-usb.c
    @@ -1075,7 +1075,7 @@ static int stir421x_patch_device(struct
    {
    unsigned int i;
    int ret;
    - char stir421x_fw_name[11];
    + char stir421x_fw_name[12];
    const struct firmware *fw;
    const unsigned char *fw_version_ptr; /* pointer to version string */
    unsigned long fw_version = 0;


    \
     
     \ /
      Last update: 2009-01-23 02:21    [W:0.023 / U:30.428 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site