lkml.org 
[lkml]   [2009]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] asm-generic: fix local_add_unless macro
    * Roel Kluin (roel.kluin@gmail.com) wrote:
    > When this macro isn't called with 'a' this will
    > result in a build failure.
    >

    Can I have a look at the offending calling code and the build failure
    output ? We might consider changing these for static inlines instead.
    And clearly, just changing a single primitive is not going to work. We
    need to address the other similar in the same file at the very least.

    Mathieu


    > Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
    > ---
    > diff --git a/include/asm-generic/local.h b/include/asm-generic/local.h
    > index dbd6150..fc21844 100644
    > --- a/include/asm-generic/local.h
    > +++ b/include/asm-generic/local.h
    > @@ -42,7 +42,7 @@ typedef struct
    >
    > #define local_cmpxchg(l, o, n) atomic_long_cmpxchg((&(l)->a), (o), (n))
    > #define local_xchg(l, n) atomic_long_xchg((&(l)->a), (n))
    > -#define local_add_unless(l, a, u) atomic_long_add_unless((&(l)->a), (a), (u))
    > +#define local_add_unless(l, _a, u) atomic_long_add_unless((&(l)->a), (_a), (u))
    > #define local_inc_not_zero(l) atomic_long_inc_not_zero(&(l)->a)
    >
    > /* Non-atomic variants, ie. preemption disabled and won't be touched

    --
    Mathieu Desnoyers
    OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68


    \
     
     \ /
      Last update: 2009-01-22 19:09    [W:0.023 / U:91.236 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site