lkml.org 
[lkml]   [2009]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC] per-CPU cryptd thread implementation based on workqueue
    On Thu, Jan 22, 2009 at 10:32:17AM +0800, Huang Ying wrote:
    >
    > This is the first attempt to use a dedicate workqueue for crypto. It is
    > not intended to be merged. Please feedback your comments, especially on
    > desgin.

    Thanks for the patch!

    > + spin_lock_init(&cpu_queue->lock);

    Since we're switching to per-cpu queues it would be good to just
    kill the spin lock. AFAICS the only place you really need it is
    in cryptd_tfm_in_queue. That's just used for debugging so we can
    just kill it and lose this spin lock.

    Cheers,
    --
    Visit Openswan at http://www.openswan.org/
    Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
    Home Page: http://gondor.apana.org.au/~herbert/
    PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


    \
     
     \ /
      Last update: 2009-01-22 04:07    [W:0.022 / U:1.512 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site