Messages in this thread | | | Date | Wed, 21 Jan 2009 17:38:38 +1100 | From | Stephen Hemminger <> | Subject | Re: why usr/include/linux/if_frad.h is required |
| |
On Tue, 20 Jan 2009 22:15:04 -0800 (PST) David Miller <davem@davemloft.net> wrote:
> From: Sam Ravnborg <sam@ravnborg.org> > Date: Wed, 21 Jan 2009 06:33:10 +0100 > > > On Wed, Jan 21, 2009 at 10:20:17AM +0530, Jaswinder Singh Rajput wrote: > > > On Wed, Jan 21, 2009 at 6:36 AM, Krzysztof Halasa <khc@pm.waw.pl> wrote: > > > > Jaswinder Singh Rajput <jaswinder@kernel.org> writes: > > > > > > > >> usr/include/linux/if_frad.h is covered with CONFIG_DLCI from many years > > > >> and no body is complaining about it so it means no body is using it. > > > >> > > > >> So should we need to drop #if / #endif pair or the whole file from > > > >> userspace. > > > > > > > > I think the file. "Empty file exported to userspace", long unused. We > > > > can also have it back there, and it being not exported is an indicator > > > > that it's not used. I guess the #ifdef __KERNEL__ can be removed, too. > > > > > > I will definately define #ifdef __KERNEL__ but I am also curious after > > > defining it there is no point of making empty > > > usr/include/linux/if_frad.h > > > > Googling a bit did not turn up _any_ non-kernel hits that has relevance. > > So based on the information given in this thread I strongly > > suggest to drop the export of this header. > > Sure, but on the other hand this makes all of the userland APIs > essentially inaccessible and undefined. > > I bet Sangoma's internal tools reference this stuff. > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
There are no references if_frad.h in the version of Sangoma (out of tree) code that we use in Vyatta.
| |