lkml.org 
[lkml]   [2009]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] usb/mcs7830: Don't use buffers from stack for USB transfers
From
From: Arnd Bergmann <arnd@arndb.de>
Date: Wed, 21 Jan 2009 00:17:18 +0100

> On Tuesday 20 January 2009, David Miller wrote:
> > + buffer = kmalloc(size, GFP_NOIO);
>
> GFP_NOIO seems out of place in a network driver: there is nothing
> wrong with waiting for I/O here, so plain GFP_KERNEL should be fine.

There seems to be a large precendence for this in other USB drivers,
both for networking and storage. Probably a mutex or other locking
hierarchy issue.

Really, I would just apply this patch as-is. It works, it's pretty
clean, and every retort has been a misunderstanding or extreme
nit-picking :-)


\
 
 \ /
  Last update: 2009-01-21 00:27    [W:0.042 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site