[lkml]   [2009]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] usb/mcs7830: Don't use buffers from stack for USB transfers
    On Tuesday 20 January 2009, you wrote:
    > From: Christian Eggers <>
    > mcs7830_set_reg() and mcs7830_get_reg() are called with buffers
    > from stack which must not be used directly for USB transfers.
    > This causes corruption of the stack particulary on non x86
    > architectures because DMA may be used for these transfers.
    > Signed-off-by: Christian Eggers <>

    Have you observed problems with this, or just suspected trouble?

    When I wrote this code, I looked at other code doing the same
    and assumed it was ok, because usb_control_msg waits for the
    DMA to complete before returning.

    Is the problem only on systems that have noncoherent DMA, or
    something else?

    > This is my first patch submission for Linux. I hope everything is fine.

    I was about to say that you should have Cc:'d me, but then I noticed
    that I'm not listed in the driver as maintainer, nor in the MAINTAINERS
    file, so I can't really complain here ;-)

    Arnd <><

     \ /
      Last update: 2009-01-20 23:49    [W:0.020 / U:31.824 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site