Messages in this thread | | | Date | Fri, 2 Jan 2009 10:57:43 +0100 (CET) | From | Geert Uytterhoeven <> | Subject | Re: [GIT PULL] XFS update for 2.6.29 |
| |
On Thu, 1 Jan 2009, Christoph Hellwig wrote: > On Thu, Jan 01, 2009 at 10:50:52AM +0100, Geert Uytterhoeven wrote: > > | fs/xfs/xfs_btree.c: In function 'xfs_btree_readahead_lblock': > > | fs/xfs/xfs_btree.c:736: warning: comparison is always true due to limited range of data type > > | fs/xfs/xfs_btree.c:741: warning: comparison is always true due to limited range of data type > > > > left/right = xfs_fsblock_t (32 or 64 bit), NULLDFSBNO = xfs_dfsbno_t (64 bit) > > Hmm, can't reproduce it here with CONFIG_LBD=n on x86, but the following
x86-32 or -64?
It may also depend on the compiler version. I have gcc version 4.1.2 20061115 (prerelease) (Debian 4.1.1-21).
> patch should fix it:
Yep, the warning is good.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |