lkml.org 
[lkml]   [2009]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/6] Hibernation: Introduce system_entering_hibernation
    On Mon, Jan 19, 2009 at 10:35:22PM +0100, Rafael J. Wysocki wrote:
    > On Monday 19 January 2009, Frederic Weisbecker wrote:
    > > On Mon, Jan 19, 2009 at 08:54:54PM +0100, Rafael J. Wysocki wrote:
    > > > From: Rafael J. Wysocki <rjw@sisk.pl>
    > > >
    > > > Introduce boolean function system_entering_hibernation() returning
    > > > 'true' during the last phase of hibernation, in which devices are
    > > > being put into low power states and the sleep state (for example,
    > > > ACPI S4) is finally entered.
    > > >
    > > > Some device drivers need such a function to check if the system is
    > > > in the final phase of hibernation. In particular, some SATA drivers
    > > > are going to use it for blacklisting systems in which the disks
    > > > should not be spun down during the last phase of hibernation (the
    > > > BIOS will do that anyway).
    > > >
    > >
    > > Hi Rafael,
    > >
    > > Why not using the power event notifier?
    >
    > I'm not sure what you mean exactly, care to elaborate?


    Sorry, I just thought about using the pm_notifier to listen on the suspend/resume
    events to check the current hibernation state.


    > Anyway, however, this is a pretty old patch series and I'm not very much
    > interested in reworking it once again. If you think it can be made better,
    > please go on. :-)


    It was just a suggestion, or more likely a question for curiosity, not really
    a criticism since I didn't follow the discussions about these patches and the
    problem they solve :-)

    Thanks.


    > Thanks,
    > Rafael



    \
     
     \ /
      Last update: 2009-01-19 22:51    [W:0.029 / U:151.028 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site