Messages in this thread | | | Date | Tue, 20 Jan 2009 01:52:51 +1100 | From | Stephen Rothwell <> | Subject | Re: [PATCH] creds: suppress warning in get_cred |
| |
Hi David,
On Mon, 19 Jan 2009 12:29:31 +0000 David Howells <dhowells@redhat.com> wrote: > > Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > > + return get_new_cred((struct cred *)(uintptr_t)cred); > > That should probably be 'unsigned long' within the kernel. This is also a > compiler bug, but I think we can live with this fix.
We do have uintptr_t inside the kernel (it is typedeffed to unsigned long) but I used it explicitly because its type is defined to be large enough to store any pointer.
However, I have also verified that using a newer compiler (4.3.2 in my case) makes the warning go away as Hannes Eder pointed out when mentioning his earlier patch.
So, your choice. -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [unhandled content-type:application/pgp-signature] | |