lkml.org 
[lkml]   [2009]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] creds: suppress warning in get_cred
    Hi David,

    On Mon, 19 Jan 2009 12:29:31 +0000 David Howells <dhowells@redhat.com> wrote:
    >
    > Stephen Rothwell <sfr@canb.auug.org.au> wrote:
    >
    > > + return get_new_cred((struct cred *)(uintptr_t)cred);
    >
    > That should probably be 'unsigned long' within the kernel. This is also a
    > compiler bug, but I think we can live with this fix.

    We do have uintptr_t inside the kernel (it is typedeffed to unsigned
    long) but I used it explicitly because its type is defined to be large
    enough to store any pointer.

    However, I have also verified that using a newer compiler (4.3.2 in my
    case) makes the warning go away as Hannes Eder pointed out when
    mentioning his earlier patch.

    So, your choice.
    --
    Cheers,
    Stephen Rothwell sfr@canb.auug.org.au
    http://www.canb.auug.org.au/~sfr/
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2009-01-19 15:59    [W:3.444 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site