lkml.org 
[lkml]   [2009]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [GIT PULL -tip] fix 41 'make headers_check' warnings
    From
    Hello Stephen,

    On Mon, Jan 19, 2009 at 9:18 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
    >> > >
    >> > > diff --git a/include/linux/pktcdvd.h b/include/linux/pktcdvd.h
    >> > > index 04b4d73..277de8c 100644
    >> > > --- a/include/linux/pktcdvd.h
    >> > > +++ b/include/linux/pktcdvd.h
    >> > > @@ -33,11 +33,15 @@
    >> > > * able to sucessfully recover with this option (drive will return good
    >> > > * status as soon as the cdb is validated).
    >> > > */
    >> > > +#ifdef __KERNEL__
    >> > > #if defined(CONFIG_CDROM_PKTCDVD_WCACHE)
    >> > > #define USE_WCACHING 1
    >> > > #else
    >> > > #define USE_WCACHING 0
    >> > > #endif
    >> > > +#else /* __KERNEL__ */
    >> > > +#define USE_WCACHING 0
    >> > > +#endif /* __KERNEL__ */
    >> >
    >> > This also only has one user (drivers/block/pktcdvd.c) so maybe it should
    >> > be moved there.
    >> >
    >>
    >> Already fixed in v3 as pointed by Ingo.
    >
    > I was actually suggesting that you move the whole
    >
    > #if defined(CONFIG_CDROM_PKTCDVD_WCACHE)
    > #define USE_WCACHING 1
    > #else
    > #define USE_WCACHING 0
    > #endif
    >
    > into drivers/block/pktcdvd.c as that is the only place USE_WCACHING is
    > used.
    >

    hmm, this is the out of scope of this patch and should be send in
    different patch.

    I think maintainers can handle this issue.

    If they need my help, they can ping me ;-)

    Thanks,

    JSR


    \
     
     \ /
      Last update: 2009-01-19 06:19    [W:0.024 / U:30.148 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site