Messages in this thread | | | Date | Mon, 19 Jan 2009 14:18:28 +0100 | From | Jan Kara <> | Subject | Re: [PATCH] sector_t last is unsigned, so cannot be less than 0. |
| |
Hi Roel,
On Sun 18-01-09 23:45:13, Roel Kluin wrote: > sector_t last is unsigned, so cannot be less than 0. > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com> > --- > diff --git a/fs/udf/super.c b/fs/udf/super.c > index e25e701..1f3941d 100644 > --- a/fs/udf/super.c > +++ b/fs/udf/super.c > @@ -721,7 +721,7 @@ static sector_t udf_scan_anchors(struct super_block *sb, sector_t lastblock) > * however, if the disc isn't closed, it could be 512 */ > > for (i = 0; i < ARRAY_SIZE(last); i++) { > - if (last[i] < 0) > + if (last[i] > lastblock + 1) > continue; > if (last[i] >= sb->s_bdev->bd_inode->i_size >> > sb->s_blocksize_bits) I already have your cleanup of this check in my UDF tree. I'm sorry it's not in Linus's tree yet but I forgot to merge it with Linus during the merge window..
Honza -- Jan Kara <jack@suse.cz> SUSE Labs, CR
| |