Messages in this thread | | | Date | Sun, 18 Jan 2009 14:14:09 +0000 | From | Alan Cox <> | Subject | Re: [PATCH] drivers/serial/8250_pci.c (add support for '8-port RS-232 MIC-3620 from advantech' |
| |
> + .vendor = PCI_VENDOR_ID_ADVANTECH, > + .device = PCI_DEVICE_ID_ADVANTECH_PCI3620, > + .subvendor = PCI_DEVICE_ID_ADVANTECH_PCI3620, > + .subdevice = PCI_ANY_ID,
This looks odd - the subvendor ought to be a vendor id, and there should be a device id as well.
> + { PCI_VENDOR_ID_ADVANTECH, PCI_DEVICE_ID_ADVANTECH_PCI3620, > + PCI_DEVICE_ID_ADVANTECH_PCI3620, PCI_ANY_ID, 0, 0, > + pbn_b2_8_921600 }, > { PCI_VENDOR_ID_V3, PCI_DEVICE_ID_V3_V960, > PCI_SUBVENDOR_ID_CONNECT_TECH, > PCI_SUBDEVICE_ID_CONNECT_TECH_BH8_232, 0, 0, > ------------------------------------- > > can you add this in the next linux kernel?
Can you firstly send me an lspci -vvxxx of that device. Also see Documentation/SubmittingPatches about Signed-off-by lines and we'll sort out merging it.
Alan
| |