Messages in this thread |  | | | Date | Mon, 19 Jan 2009 14:53:45 +1100 | | From | Stephen Rothwell <> | | Subject | Re: [GIT PULL -tip] fix 41 'make headers_check' warnings |
| |
Hi Jaswinder,
On Mon, 19 Jan 2009 08:00:40 +0530 Jaswinder Singh Rajput <jaswinder@kernel.org> wrote: > > On Mon, 2009-01-19 at 09:50 +1100, Stephen Rothwell wrote: > > Hi Jaswinder, > > > > On Sun, 18 Jan 2009 15:40:54 +0530 Jaswinder Singh Rajput <jaswinder@kernel.org> wrote: > > > > > > diff --git a/include/linux/raw.h b/include/linux/raw.h > > > index 62d543e..3898e30 100644 > > > --- a/include/linux/raw.h > > > +++ b/include/linux/raw.h > > > @@ -13,6 +13,10 @@ struct raw_config_request > > > __u64 block_minor; > > > }; > > > > > > +#ifdef __KERNEL__ > > > #define MAX_RAW_MINORS CONFIG_MAX_RAW_DEVS > > > +#else /* __KERNEL__ */ > > > +#define MAX_RAW_MINORS 0 > > > +#endif /* __KERNEL__ */ > > > > > > #endif /* __LINUX_RAW_H */ > > > > Since MAX_RAW_MINORS has only one user (drivers/char/raw.c), why not > > just remove the define from here and add it it there? > > > > Already fixed in v3 as pointed by Ingo.
Again I was suggesting that the whole #define line could be moved to the only C files it is used in.
-- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [unhandled content-type:application/pgp-signature] |  |