Messages in this thread | | | Date | Sun, 18 Jan 2009 21:53:30 +0100 | From | Sam Ravnborg <> | Subject | Re: [PATCH] kbuild: auto-convert size types in userspace headers |
| |
On Tue, Dec 30, 2008 at 09:42:47AM -0800, H. Peter Anvin wrote: > Sam Ravnborg wrote: > > On Mon, Dec 29, 2008 at 03:35:45PM -0800, H. Peter Anvin wrote: > >> Sam Ravnborg wrote: > >>> On Mon, Dec 29, 2008 at 06:12:33AM -0500, Mike Frysinger wrote: > >>>> Rather than constantly fixing up size type breakage in userspace headers, > >>>> auto convert the types u_intXX_t, uintXX_t, intXX_t, uXX, and sXX to the > >>>> appropriate __uXX or __sXX type. > >>> Is this the right thing to do? > >>> uintXX_t belongs to a namespace that the kernel should not use. > >>> > >>> So being restrictive here would be better I think. > >> That's the whole point right here. > >> > >> All of these types can be -- and are -- used by the kernel internally, > >> but should only be exported as __uXX or __sXX. > >> > >> This is the auto-conversion idea I brought up earlier. > > > > So the patch from Mike has your "Acked-by"? > > > > Acked-by: H. Peter Anvin <hpa@zytor.com>
Hi hpa.
Despite your ack I chickened out on this one. We have enough crunch in the userspace headers for now, so lets see where we end with this before doing any autoconversion.
Sam
| |