Messages in this thread | | | Date | Sun, 18 Jan 2009 20:45:10 +0100 | From | Sam Ravnborg <> | Subject | Re: [GIT PULL -tip v3] fix 39 'make headers_check' warnings |
| |
On Sun, Jan 18, 2009 at 08:09:41PM +0100, Ingo Molnar wrote: > * Sam Ravnborg <sam@ravnborg.org> wrote: > > > On Sun, Jan 18, 2009 at 07:50:34PM +0100, Ingo Molnar wrote: > > > > > > hm, i just noticed this detail: > > > > > > commit 3521c5eef990515719614e212b26ea49e610d072 > > > Author: Jaswinder Singh Rajput <jaswinderrajput@gmail.com> > > > Date: Sat Jan 17 19:25:46 2009 +0530 > > > > > > headers_check fix: x86, swab.h > > > > > > fix the following 'make headers_check' warnings: > > > > > > usr/include/asm/swab.h:4: include of <linux/types.h> is preferred over <asm/types.h> > > > usr/include/asm/swab.h:7: found __[us]{8,16,32,64} type without #include <linux/types.h> > > > usr/include/asm/swab.h:10: leaks CONFIG_X86 to userspace where it is not valid > > > usr/include/asm/swab.h:40: leaks CONFIG_X86 to userspace where it is not valid > > > > > > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com> > > > Signed-off-by: Ingo Molnar <mingo@elte.hu> > > > > > > diff --git a/arch/x86/include/asm/swab.h b/arch/x86/include/asm/swab.h > > > index 306d417..613be68 100644 > > > --- a/arch/x86/include/asm/swab.h > > > +++ b/arch/x86/include/asm/swab.h > > > @@ -1,12 +1,15 @@ > > > #ifndef _ASM_X86_SWAB_H > > > #define _ASM_X86_SWAB_H > > > > > > -#include <asm/types.h> > > > +#include <linux/types.h> > > > +#ifdef __KERNEL__ > > > #include <linux/compiler.h> > > > +#endif /* __KERNEL__ */ > > > > compiler.h includes should be nuked by make headers_instll automatically. > > So the compiler.h include can be left there, and headers_check will not > warn about it?
Correct.
Sam
| |