lkml.org 
[lkml]   [2009]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateSun, 18 Jan 2009 13:58:01 +0900
FromTejun Heo <>
SubjectRe: [PATCH 03/17] x86-64: Convert irqstacks to per-cpu
Hello,

Brian Gerst wrote:
> @@ -211,15 +211,13 @@ ENTRY(secondary_startup_64)
> * data area. Computing this requires two symbols - __per_cpu_load
> * and per_cpu__gdt_page. As linker can't do no such relocation, do
> * it by hand. As early_gdt_descr is manipulated by C code for
> - * secondary CPUs, this should be done only once for the boot CPU
> - * when early_gdt_descr_base contains zero.
> + * secondary CPUs, this should be done only once for the boot CPU.
> */

It would probably be nice to mention that it's calculating per cpu
load addresses for early access. The comment only refers to gdt_page
which is a bit misleading as it now also adjusts irqstackptr.

Also, as pda field name, irqstackptr might be fine but wouldn't it be
better to rename it to at least irq_stack_ptr as this change requires
touching every users anyway?

Thanks.

--
tejun


\
 
 \ /
  Last update: 2009-01-18 06:01    [from the cache]
©2003-2010