lkml.org 
[lkml]   [2009]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/7][v7] Protect cinit from unblocked SIG_DFL signals
    On 01/17, Sukadev Bhattiprolu wrote:
    >
    > @@ -1331,7 +1341,7 @@ int send_sigqueue(struct sigqueue *q, struct task_struct *t, int group)
    > goto ret;
    >
    > ret = 1; /* the signal is ignored */
    > - if (!prepare_signal(sig, t))
    > + if (!prepare_signal(sig, t, 1))

    Hmm, just noticed. This looks wrong, it should be prepare_signal(sig, t, 0),
    no?

    For example, /sbin/init can create the posix timer with sigev_signo = SIGKILL
    and it won't be killed before this patch.

    This also looks wrong from the masquerading pov.


    Otherwise, the patches 1-6 are imho fine.

    Oleg.



    \
     
     \ /
      Last update: 2009-01-17 23:17    [W:0.024 / U:1.080 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site