lkml.org 
[lkml]   [2009]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] Remove needless flush_dcache_page call
Now, Anyone don't maintain cramfs.
I don't know who is maintain romfs. so I send this patch to linux-mm,
lkml, linux-dev.

I am not sure my thought is right.

When readpage is called, page with argument in readpage is just new
allocated because kernel can't find that page in page cache.

At this time, any user process can't map the page to their address space.
so, I think D-cache aliasing probelm never occur.

It make sense ?

---
diff --git a/arch/arm/mach-integrator/clock.h b/arch/arm/mach-integrator/clock.h
deleted file mode 100644
index e69de29..0000000
diff --git a/fs/cramfs/inode.c b/fs/cramfs/inode.c
index a07338d..40c8b84 100644
--- a/fs/cramfs/inode.c
+++ b/fs/cramfs/inode.c
@@ -492,7 +492,6 @@ static int cramfs_readpage(struct file *file, struct page * page)
pgdata = kmap(page);
memset(pgdata + bytes_filled, 0, PAGE_CACHE_SIZE - bytes_filled);
kunmap(page);
- flush_dcache_page(page);
SetPageUptodate(page);
unlock_page(page);
return 0;
diff --git a/fs/romfs/inode.c b/fs/romfs/inode.c
index 98a232f..d008262 100644
--- a/fs/romfs/inode.c
+++ b/fs/romfs/inode.c
@@ -454,7 +454,6 @@ romfs_readpage(struct file *file, struct page * page)

if (!result)
SetPageUptodate(page);
- flush_dcache_page(page);

unlock_page(page);

\
 
 \ /
  Last update: 2009-01-16 06:31    [W:0.040 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site