lkml.org 
[lkml]   [2009]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [GIT PATCH] firs round of SCSI bug fixes for 2.6.29-rc1
From
On Fri, Jan 16, 2009 at 9:09 AM, Andrew Morton
<akpm@linux-foundation.org> wrote:
...
>> + CHIPREG_WRITE32(&ioc->chip->Doorbell, 0xC0FFEE00);
>> + panic("%s: Firmware is halted due to command timeout\n",
>> + ioc->name);
>> + }
>> +}
>> +EXPORT_SYMBOL(mpt_halt_firmware);
>
> Doing a panic() after we've already detected an error is plain nasty.
> Is there no way in which we can allow the kernel to continue?

Basically what James said. It's not long though: only 6 emails.
I started that thread thinking the same thing you did:
http://marc.info/?t=123123569200003&r=1&w=2
TBH, I still wouldn't implement it the way LSI maintainers did.
I'm happy they are the maintainers and it's their call.

grant


\
 
 \ /
  Last update: 2009-01-16 20:05    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site