Messages in this thread | | | Date | Fri, 16 Jan 2009 11:02:12 -0800 | Subject | Re: [GIT PATCH] firs round of SCSI bug fixes for 2.6.29-rc1 | From | Grant Grundler <> |
| |
On Fri, Jan 16, 2009 at 9:09 AM, Andrew Morton <akpm@linux-foundation.org> wrote: ... >> + CHIPREG_WRITE32(&ioc->chip->Doorbell, 0xC0FFEE00); >> + panic("%s: Firmware is halted due to command timeout\n", >> + ioc->name); >> + } >> +} >> +EXPORT_SYMBOL(mpt_halt_firmware); > > Doing a panic() after we've already detected an error is plain nasty. > Is there no way in which we can allow the kernel to continue?
Basically what James said. It's not long though: only 6 emails. I started that thread thinking the same thing you did: http://marc.info/?t=123123569200003&r=1&w=2
TBH, I still wouldn't implement it the way LSI maintainers did. I'm happy they are the maintainers and it's their call.
grant
| |