lkml.org 
[lkml]   [2009]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [git patches] libata fixes
From
On Fri, Jan 16, 2009 at 9:31 AM, Andrew Morton
<akpm@linux-foundation.org> wrote:
...
>> +static void octeon_cf_tf_read16(struct ata_port *ap, struct ata_taskfile *tf)
>> +{
>> + u16 blob;
>> + /* The base of the registers is at ioaddr.data_addr. */
>> + void __iomem *base = ap->ioaddr.data_addr;
>> +
>> + blob = __raw_readw(base + 0xc);
>
> why __raw?

Avoid byte swapping. If it's "native" HW on Big Endian platform,
byte swapping isn't needed. If it's working, it's correct.

hth,
grant


\
 
 \ /
  Last update: 2009-01-16 19:53    [W:0.069 / U:0.612 seconds]
©2003-2014 Jasper Spaans. Advertise on this site