Messages in this thread | | | Date | Fri, 16 Jan 2009 10:49:19 -0800 | Subject | Re: [git patches] libata fixes | From | Grant Grundler <> |
| |
On Fri, Jan 16, 2009 at 9:31 AM, Andrew Morton <akpm@linux-foundation.org> wrote: ... >> +static void octeon_cf_tf_read16(struct ata_port *ap, struct ata_taskfile *tf) >> +{ >> + u16 blob; >> + /* The base of the registers is at ioaddr.data_addr. */ >> + void __iomem *base = ap->ioaddr.data_addr; >> + >> + blob = __raw_readw(base + 0xc); > > why __raw?
Avoid byte swapping. If it's "native" HW on Big Endian platform, byte swapping isn't needed. If it's working, it's correct.
hth, grant
| |