lkml.org 
[lkml]   [2009]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Allow SysRq emergency sync to thaw frozen filesystems
From
Date
On Fri, 2009-01-16 at 10:21 -0600, Dave Kleikamp wrote:
> On Thu, 2009-01-15 at 21:49 -0600, Eric Sandeen wrote:

> > oh, hrm. Maybe I didn't think enough about how it's handed off to
> > pdflush; I could rearrange if that makes sense? Or maybe handing to
> > pdflush is wrong, it was just so convenient....
>
> I don't understand the reason for handing it to pdflush. I would expect
> thaw to be very fast. Do we expect it to block anywhere, and if so, for
> very long? Not that I see any problem with it.

Eric pointed out on irc that this is in interrupt context, so even
taking a mutex is not allowed. I now agree that handing it to pdflush
is reasonable.

Shaggy
--
David Kleikamp
IBM Linux Technology Center



\
 
 \ /
  Last update: 2009-01-16 17:45    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site