Messages in this thread | | | From | "Metzger, Markus T" <> | Date | Fri, 16 Jan 2009 14:59:37 +0000 | Subject | RE: [patch 1/5] x86, ftrace, hw-branch-tracer: support hotplug cpus |
| |
>-----Original Message----- >From: Steven Rostedt [mailto:srostedt@redhat.com] >Sent: Friday, January 16, 2009 3:48 PM >To: Metzger, Markus T
>> + local_irq_save(irq1); >> + cpu = raw_smp_processor_id(); >> + if (atomic_inc_return(&tr->data[cpu]->disabled) != 1) >> + goto out; >> >> - event = ring_buffer_lock_reserve(tr->buffer, sizeof(*entry), &irq); >> + event = ring_buffer_lock_reserve(tr->buffer, sizeof(*entry), &irq2); >> if (!event) >> return; > >You need a goto out here, otherwise you leave with interrupts disabled. >
Thanks. I will fix it and send an updated patch.
regards, markus.
--------------------------------------------------------------------- Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen Germany Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer Registergericht: Muenchen HRB 47456 Ust.-IdNr. VAT Registration No.: DE129385895 Citibank Frankfurt (BLZ 502 109 00) 600119052
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
| |