Messages in this thread | | | Date | Thu, 15 Jan 2009 20:46:38 -0500 (EST) | From | Steven Rostedt <> | Subject | Re: [PATCH 1/2] ftrace: fix trace_output |
| |
On Thu, 15 Jan 2009, Andrew Morton wrote: > > > > diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c > > index df0c25c..4e3ad36 100644 > > --- a/kernel/trace/trace_output.c > > +++ b/kernel/trace/trace_output.c > > @@ -440,9 +440,9 @@ trace_fn_raw(struct trace_seq *s, struct trace_entry *entry, int flags) > > > > trace_assign_type(field, entry); > > > > - if (trace_seq_printf(s, "%x %x\n", > > - field->ip, > > - field->parent_ip)) > > + if (!trace_seq_printf(s, "%x %x\n", > > "%lx %lx", surely? > > If trace_seq_printf() had the attribute(printf) thing, it would have warned.
Who needs automation when we have an akpm ;-)
Will update.
Thanks,
-- Steve
| |