lkml.org 
[lkml]   [2009]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: deadlocks if use htb
From
On Thu, 15 Jan 2009, Jarek Poplawski wrote:
> On Wed, Jan 14, 2009 at 06:02:04PM +0000, Chris Caputo wrote:
> ...
> > That said, I would not recommend just the three for -stable unless they
> > get a much wider amount of testing, on multiple platforms. I don't see
> > that as likely to happen, plus Peter says they are incomplete, so maybe it
> > is just best to recommend that 2.6.28 users getting crashes while using
> > HTB try these specific patches at first, and then the rest of the patches
> > if they do not work.
>
> The main problem is my patches, at least the tested ones, harm htb's
> exactness, and I doubt I could convince anybody to merege them, at
> least before your case. It was only reported by two users here (plus
> one more on private), and looked like something very rare. After your
> report it looks much more necessary.
>
> If there is nothing better, I can recommend it, but IMHO the best
> candidate for this is the testing patch #4 from this thread, which
> alas wasn't even tested... So, Chris, if you could give it a try in
> the meantime (without any other patches)?
>
> Thanks,
> Jarek P.
>
> (resend testing patch #4 - for 2.6.27 or 2.6.28)
> ---
>
> diff -Nurp a2.6.27.7/net/sched/sch_htb.c b2.6.27.7/net/sched/sch_htb.c
> --- a2.6.27.7/net/sched/sch_htb.c 2008-12-11 08:16:16.000000000 +0000
> +++ b2.6.27.7/net/sched/sch_htb.c 2008-12-15 10:44:32.000000000 +0000
> @@ -924,6 +924,7 @@ static struct sk_buff *htb_dequeue(struc
> }
> }
> sch->qstats.overlimits++;
> + qdisc_watchdog_cancel(&q->watchdog);
> qdisc_watchdog_schedule(&q->watchdog, next_event);
> fin:
> return skb;

I hope you can forgive me, but since I have something that works on a
production machine, I am not in a position in which I can test this.

Chris


\
 
 \ /
  Last update: 2009-01-15 08:37    [W:0.807 / U:0.376 seconds]
©2003-2011 Jasper Spaans. Advertise on this site