![]() | |||||||||||||
Messages in this thread
Patch in this message |
2.6.28-stable review patch. If anyone has any objections, please let us know. ------------------ From: Jiri Kosina <jkosina@suse.cz> commit 4dfdc46468a142216b284eea66040f49df3f7191 upstream. sony_set_operational() only propagates return value from usb_control_msg(), which returns negative on error and number of transferred bytes otherwise. Reported-by: Marcin Tolysz <tolysz@gmail.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/hid/hid-sony.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/hid/hid-sony.c +++ b/drivers/hid/hid-sony.c @@ -102,7 +102,7 @@ static int sony_probe(struct hid_device } ret = sony_set_operational(hdev); - if (ret) + if (ret < 0) goto err_stop; return 0; | ||||||||||||
| Last update: 2009-01-15 21:53 [from the cache] ©2003-2008 | |||||||||||||