Messages in this thread | | | Date | Thu, 15 Jan 2009 20:41:40 +0100 | From | wk <> | Subject | Re: [linux-dvb] compiling on 2.6.28 broken? |
| |
Dave Chinner wrote: > On Wed, Jan 14, 2009 at 10:19:39PM +0100, wk wrote: > >> Chris Mason wrote: >> I cannot fully understand what strace -v outputs (see attachment), but >> what i see is that 'find' stops after finding a file with d_off = >> 4294967295 >> 4294967295 = 0xFFFFFFFF, adding any number greater that zero will be >> greater that 32bits, so this could be the reason for the message "value >> too large". >> >> >> >> I also noticed that i cannot access these files through samba if i boot >> from 2.6.28 - really strange. >> If i reboot older kernels these are visible in samba again and fully >> accessible. >> >> Attached the log from stracing the command which was ivoked by the >> Makefile from v4l-dvb. >> I guess this is all i could contribute to that problem. Thats stuff for >> xfs filesystem experts now.. >> > > It's obviously the regression fixed by: > > http://oss.sgi.com/cgi-bin/gitweb.cgi?p=xfs/xfs.git;a=commit;h=15440319767942a363f282d6585303d3d75088ba > > It needs to be pushed to Linus, then into 2.6.28-stable. > > Cheers, > > Dave. >
Yes, that solves the problems as expected. But may i kindly ask the xfs fs developers to put some more readable patch here, so that its better understandable by looking at the source code? I think some macro would be better here, for example i used
#define TRUNC_TO_SIGNED32(x) (x & 0x7FFFFFFF)
inside xfs.h and replaced all "foo & 0x7fffffff" with "TRUNC_TO_SIGNED32(foo)".
Thanks for your help, Winfried
| |