Messages in this thread | | | Subject | Re: Performance regression of specjbb2005/aim7 with 2.6.29-rc1 | From | Peter Zijlstra <> | Date | Thu, 15 Jan 2009 16:10:58 +0100 |
| |
On Thu, 2009-01-15 at 10:30 +0800, Lin Ming wrote:
> diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c > index 8e1352c..617e54c 100644 > --- a/kernel/sched_fair.c > +++ b/kernel/sched_fair.c > @@ -429,10 +429,10 @@ static u64 sched_slice(struct cfs_rq *cfs_rq, struct sched_entity *se) > u64 slice = __sched_period(cfs_rq->nr_running + !se->on_rq); > > for_each_sched_entity(se) { > - struct load_weight *load = &cfs_rq->load; > + struct load_weight *load = &cfs_rq_of(se)->load; > > if (unlikely(!se->on_rq)) { > - struct load_weight lw = cfs_rq->load; > + struct load_weight lw = cfs_rq_of(se)->load; > > update_load_add(&lw, se->load.weight); > load = &lw; >
I was wrong, this does look good.
Thanks
| |