lkml.org 
[lkml]   [2009]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] lib/idr.c: Zero memory properly in idr_remove_all
On Wed, Jan 14, 2009 at 12:48 AM, Andrew Morton
<akpm@linux-foundation.org> wrote:
>> >> If the idr code passes uninitialized objects to kmem_cache_free(), then
>> >> the next kmem_cache_alloc will return a bad object.
>> >>
>> >
>> > None of this got us much closer to fixing the bug ;)
>> >
>> > What do we think of just removing the constructor and using
>> > kmem_cache_zalloc()?

On Wed, 14 Jan 2009 09:19:01 +0200 "Pekka Enberg"
<penberg@cs.helsinki.fi> wrote:
>> Why do I get the feeling that we have merged a similar patch before?

On Wed, Jan 14, 2009 at 10:17 AM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> Dunno - maybe we had the same bug in other places.

It's probably commit 571817849c76aabf34d534c905b5e604f2e824c5 ("msi:
use kmem_cache_zalloc()"). But the changelog is bit, uhm, limited on
the subject... oh well.

Pekka


\
 
 \ /
  Last update: 2009-01-14 10:05    [from the cache]
©2003-2011 Jasper Spaans