Messages in this thread | | | Date | Wed, 14 Jan 2009 16:45:46 +0800 | From | Li Zefan <> | Subject | Re: [PATCH] memcg: fix return value of mem_cgroup_hierarchy_write() |
| |
Balbir Singh wrote: > * Li Zefan <lizf@cn.fujitsu.com> [2009-01-14 16:10:52]: > >> When there are sub-dirs, writing to memory.use_hierarchy returns -EBUSY, >> this doesn't seem to fit the meaning of EBUSY, and is inconsistent with >> memory.swappiness, which returns -EINVAL in this case. >> >> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> > > The patch does much more than the changelog says. The reason for EBUSY > is that the group is in use due to children or existing references and > tasks. I think EBUSY is the correct error code to return. >
Sounds reasonable for me. Thanks.
Regards Li Zefan
| |